Change tda to non tda and vice versa #4367
Conversation
When changing from non TDA to TDA course: Make sure full time is set on site statuses When changing from TDA to non TDA course: Make sure A level is clear
Also hide the change outcome links when the course is TDA and published
| else | ||
| raise "Unexpected study mode #{study_mode}" | ||
| end | ||
| end |
There was a problem hiding this comment.
This method was in a controller concern and was included in the Course model (only on course) so I remove the module and move the code here.
|
|
||
| qts_list - %w[undergraduate_degree_with_qts] | ||
| qts_list |
There was a problem hiding this comment.
I really wish one day to refactor the whole Edit options code because at least to me sounds wrong changing this module to remove an option in the view. And changing this module will affect different screens that uses the edit options.
I think the EditOption abstraction is bringing more problems than solutions. But maybe is just me.
To solve this bug I have to add the condition above.
There was a problem hiding this comment.
The code looks good to me. And most of the bugs have been fixed
I still managed to change the course from TDA to something else when it's published but not as easy. Feels like something is changing when I get pundit policy tries to stop me.
Peek.2024-07-12.11-15.mp4
Interesting. I did test for the published but not when is scheduled state. 🤔 |
|
@CatalinVoineag I pushed the fix. I optin to move everything to Pundit but to redirect away if you enter manually on the page. |
Context
There were 4 bug cards from the bug party:
https://trello.com/c/9VaxXZ1f/2004-bug-investigate-recreating-403-access-issue-you-are-not-permitted-to-see-this-page-when-switching-a-tda-course-to-non-tda?filter=label:Squad%20B
https://trello.com/c/5HipohNv/2007-bug-investigate-broken-tda-course-that-wont-publish
https://trello.com/c/YuJcPxuE/1968-tda-publish-edge-case-reset-the-a-levels-when-user-changes-from-a-tda-course-to-a-non-tda-course
https://trello.com/c/n791FkBt/2013-bug-changing-back-to-tda-having-changed-to-non-tda-ends-up-being-unpublishable
These are always part of the same problem:
Changes implemented
We should allow to change from TDA <-> non TDA when draft or rollover. But not when the course is published.
Guidance to review